Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement nextExchangeRate property inside TransactionReceipt #2170

Merged
merged 3 commits into from
Jan 14, 2025

Conversation

naydenovn
Copy link
Contributor

@naydenovn naydenovn commented Jan 14, 2025

Description:
Added nextExchangeRate property inside TransactionReceipt

Related issue(s):

Fixes #2122
Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@naydenovn naydenovn self-assigned this Jan 14, 2025
@naydenovn naydenovn requested a review from a team as a code owner January 14, 2025 11:17
@naydenovn naydenovn requested a review from SimiHunjan January 14, 2025 11:17
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.41%. Comparing base (b86ee46) to head (0b680f0).
Report is 215 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2170      +/-   ##
============================================
+ Coverage     82.20%   82.41%   +0.21%     
- Complexity     3588     4042     +454     
============================================
  Files           186      205      +19     
  Lines         11697    12919    +1222     
  Branches       1150     1283     +133     
============================================
+ Hits           9615    10647    +1032     
- Misses         1604     1814     +210     
+ Partials        478      458      -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@0xivanov 0xivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, can you also add 1 integration test that verifies receipt.nextExchangeRate is not null?

Signed-off-by: Naydenov <[email protected]>
Copy link
Contributor

@0xivanov 0xivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xivanov 0xivanov merged commit d848d45 into main Jan 14, 2025
11 checks passed
@0xivanov 0xivanov deleted the 2122-nextExchangeRate branch January 14, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new property nextExchangeRate in the receipt
2 participants